Moving and renaming distance namespaces from raft -> cuvs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
… into fea-2406-move_raft_distance
benfred
approved these changes
Apr 23, 2024
… into fea-2406-move_raft_distance
|
/merge |
benfred
approved these changes
Apr 26, 2024
|
/merge |
raydouglass
approved these changes
Apr 26, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR #85 added a dependency on `libnvjitlink`. This was needed only temporarily, due to an issue with a particular build of `cupy` that caused an undesired conda environment. This should be safe to remove. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #97
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
raft::distanceAPIs over to cuVS. We're ripping the band-aid off quickly here so moving all over at once.All of the non-public APIs are being moved to
src/distanceand only the public APIs being moved toinclude/cuvs/distance.