Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy <2 pin #622

Draft
wants to merge 7 commits into
base: branch-24.10
Choose a base branch
from
Draft

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Aug 19, 2024

This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).

EDIT: Sorry, converted back to draft again, NumPy 2 is not yet picked up.

@seberg seberg added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 19, 2024
@seberg seberg closed this Aug 28, 2024
@seberg seberg reopened this Aug 28, 2024
@seberg seberg marked this pull request as ready for review August 28, 2024 11:22
@seberg seberg requested a review from a team as a code owner August 28, 2024 11:22
@seberg seberg requested a review from msarahan August 28, 2024 11:22
@seberg seberg marked this pull request as draft August 28, 2024 11:22
@jakirkham
Copy link
Member

Note that cuxfilter depends on cuspatial

- &cuspatial_unsuffixed cuspatial==24.10.*,>=0.0.0a0

So this depends on PR: rapidsai/cuspatial#1441

@jakirkham
Copy link
Member

cc @jameslamb (for awareness)

@seberg
Copy link
Contributor Author

seberg commented Aug 29, 2024

Yeah, sorry, I unmarked draft too early, but I think once things are in place and NumPy is picked up we can make it no-draft again and it should be good.

@jakirkham
Copy link
Member

All good. Was more looping in James as we had discussed the cuSpatial NumPy 2 PR earlier

@github-actions github-actions bot added the ci label Sep 19, 2024
@jameslamb jameslamb self-assigned this Sep 19, 2024
@jameslamb
Copy link
Member

I've taken over rapidsai/cuspatial#1441 and so am testing here too.

Got cuspatial to a state where it can be installed alongside Numpy (2.0.2): rapidsai/cuspatial#1441 (comment)

I pushed commits here to use the packages built from that PR's CI. Let's see if it'll be enough to loosen the pin here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants