Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RD-14762: SqlCompilerService crashes on default null date parameter #514

Merged
merged 2 commits into from
Sep 17, 2024
Merged

RD-14762: SqlCompilerService crashes on default null date parameter #514

merged 2 commits into from
Sep 17, 2024

Conversation

bgaidioz
Copy link
Collaborator

Same for TIME and TIMESTAMP. Other types wouldn't crash, but they end up as e.g. a RawString that embeds a null string, instead of being a RawNull.

torcato
torcato approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@torcato torcato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgaidioz bgaidioz merged commit c9f7876 into main Sep 17, 2024
7 checks passed
@bgaidioz bgaidioz deleted the RD-14762-execution-crash-report-com-rawlabs-compiler-compiler-service-exception branch September 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcato torcato torcato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgaidioz @torcato