Refactor: EarlyExit

phpcs.xml

@@ -40,7 +40,6 @@ com
         <exclude name="SlevomatCodingStandard.Classes.SuperfluousTraitNaming.SuperfluousSuffix"/>
         <!-- /Base -->
         <!-- Option -->
-        <exclude name="SlevomatCodingStandard.ControlStructures.EarlyExit.EarlyExitNotUsed"/>
         <exclude name="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall.MissingTrailingComma"/>
         <!-- /Option -->
         <!-- Exclude Fake files form Doctrine CS -->

src/AopCodeGen.php

@@ -121,8 +121,10 @@ private function addMethods(AopCodeGenNewCode $newCode, ReflectionClass $class,
             $additionalMethods[] = sprintf("    %s\n    {\n        %s%s\n    }\n", $signature, $return, self::INTERCEPT_STATEMENT);
         }
 
-        if ($additionalMethods) {
-            $newCode->insert(implode("\n", $additionalMethods));
+        if (! $additionalMethods) {
+            return;
         }
+
+        $newCode->insert(implode("\n", $additionalMethods));
     }
 }

src/Matcher/AnyMatcher.php

@@ -21,9 +21,11 @@ public function __construct()
     {
         parent::__construct();
 
-        if (self::$builtinMethods === []) {
-            $this->setBuildInMethods();
+        if (self::$builtinMethods !== []) {
+            return;
         }
+
+        $this->setBuildInMethods();
     }
 
     /**

src/MethodMatch.php

@@ -30,10 +30,12 @@ public function __invoke(ReflectionClass $class, \Ray\Aop\ReflectionMethod $meth
         $annotations = $method->getAnnotations();
         // priority bind
         foreach ($pointcuts as $key => $pointcut) {
-            if ($pointcut instanceof PriorityPointcut) {
-                $this->annotatedMethodMatchBind($class, $method, $pointcut);
-                unset($pointcuts[$key]);
+            if (! ($pointcut instanceof PriorityPointcut)) {
+                continue;
             }
+
+            $this->annotatedMethodMatchBind($class, $method, $pointcut);
+            unset($pointcuts[$key]);
         }
 
         $onion = $this->onionOrderMatch($class, $method, $pointcuts, $annotations);
@@ -78,10 +80,12 @@ private function onionOrderMatch(
         // method bind in annotation order
         foreach ($annotations as $annotation) {
             $annotationIndex = get_class($annotation);
-            if (array_key_exists($annotationIndex, $pointcuts)) {
-                $this->annotatedMethodMatchBind($class, $method, $pointcuts[$annotationIndex]);
-                unset($pointcuts[$annotationIndex]);
+            if (! array_key_exists($annotationIndex, $pointcuts)) {
+                continue;
             }
+
+            $this->annotatedMethodMatchBind($class, $method, $pointcuts[$annotationIndex]);
+            unset($pointcuts[$annotationIndex]);
         }
 
         return $pointcuts;

src/ReflectiveMethodInvocation.php

@@ -87,11 +87,13 @@ public function getNamedArguments(): ArrayObject
         $namedParams = [];
         foreach ($params as $param) {
             $pos = $param->getPosition();
-            if (array_key_exists($pos, (array) $args)) {
-                $name = $param->getName();
-                /** @psalm-suppress MixedAssignment */
-                $namedParams[$name] = $args[$pos];
+            if (! array_key_exists($pos, (array) $args)) {
+                continue;
             }
+
+            $name = $param->getName();
+            /** @psalm-suppress MixedAssignment */
+            $namedParams[$name] = $args[$pos];
         }
 
         return new ArrayObject($namedParams); // @phpstan-ignore-line