Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvn-golang:vet does not have maven dependency resolution #59

Closed
dantran opened this issue Jun 12, 2019 · 7 comments
Closed

mvn-golang:vet does not have maven dependency resolution #59

dantran opened this issue Jun 12, 2019 · 7 comments
Assignees
Labels
Milestone

Comments

@dantran
Copy link

dantran commented Jun 12, 2019

My build with mvn-golang:vet fails due to lack of GOPATH setup

I believe 'vet' goal should shave the same maven dependency resolution of the 'build' goal: requiresDependencyResolution = ResolutionScope.COMPILE

@raydac
Copy link
Owner

raydac commented Jun 12, 2019

could you describe situation more detailed? step by step to reproduce

@dantran
Copy link
Author

dantran commented Jun 12, 2019

sorry about the confusion, i have multi maven modules with Go and I would like to run mvn-golang:vet
In this example, 2 modules should be sufficient

common
main

main depends on common via mvn-golang maven dependency

Normal 'build' gold works, since main module can reference 'common' via GOPATH which is set correctly ( ends with target/dep/common-x.y.x)

'vet' goal fail to find 'common' since GOPATH does not have 'common' in its path

@raydac raydac self-assigned this Jun 12, 2019
@raydac raydac added the bug label Jun 12, 2019
@raydac raydac added this to the 2.1.1 milestone Jun 12, 2019
@raydac
Copy link
Owner

raydac commented Jun 12, 2019

good point, I will add a test for such case and fix

@raydac raydac modified the milestones: 2.1.1, 2.3.1 Jun 12, 2019
@dantran
Copy link
Author

dantran commented Jun 12, 2019

will you deploy a snapshot to sonatype snapshot repo?love to test it as soon as it is available

@dantran
Copy link
Author

dantran commented Jun 15, 2019

the fix looks good, I am able to see Go Vet result. Many thanks.

@raydac
Copy link
Owner

raydac commented Jun 15, 2019

I will add test for other go commands and if all is ok then release new version

@raydac
Copy link
Owner

raydac commented Jun 24, 2019

I have published 2.3.2 version with the fix in maven central

@raydac raydac closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants