Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows OS/module mode: Can't extract module info from tokens #80

Closed
fmazoyer opened this issue Jan 26, 2021 · 1 comment
Closed

Windows OS/module mode: Can't extract module info from tokens #80

fmazoyer opened this issue Jan 26, 2021 · 1 comment

Comments

@fmazoyer
Copy link
Contributor

On Windows OS, I am getting the following error:

   Can't extract module info from tokens: [a/b/c, =>, .., .., .., .., ..,module1-directory-1.0.0, src, a, b, c] `

Problem can easily be reproduced by slightly modifying JUnit: GoModTest.java:testComplex4, replacing ../goodbye with ..\goodbye.

  1. module2 depends on module1:
    module2's go.mod in bin\.__deps__\module2-directory-1.0.0\src\d\e\f looks like:
module d/e/f
require a/b/c v1.0.0
replace a/b/c => ..\..\..\..\..\module1-directory-1.0.0\src\a\b\c
go 1.15
  1. Question: Is this ok to have backslashes here, even though we are on Windows OS?

If not, it looks like backslash character is not taken as a token separator?:

If you would agree that there is a problem, indeed, I tested a simple modification in TOKENIZER, by adding backslash as a separator, and my build is working again.
I can push it for review.

If not, I will let it up to you :-)

Thanks a lot for this great tool!

Kind regards.

@raydac
Copy link
Owner

raydac commented Jan 27, 2021

Hi
thanks for info, good point
if you have fix for the issue, you could make pull-request

@raydac raydac closed this as completed in 12ac6f5 Jan 28, 2021
raydac added a commit that referenced this issue Jan 28, 2021
Fixed #80 - take backslash into account in TOKENIZER for Windows path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants