Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: update Node minimum version to 18 #1986

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

Shubham1429
Copy link
Contributor

@Shubham1429 Shubham1429 commented Jun 26, 2023

Summary:

Set minimum Node version to 18.

Part of #1936

Reference: facebook/react-native#37709

@szymonrybczak szymonrybczak changed the title chore (doctor): update Node minimum version to 18 breaking: update Node minimum version to 18 Jul 4, 2023
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You need also to change node version in the engines in package.json, see here:

"engines": {
"node": ">=16"
},

also @types/node in few packages, in babel.config.js and in .github/workflows/test.yml just leave Node 18 for running unit tests.

@thymikee
Copy link
Member

@Shubham1429 can you rebase and address the feedback? :)

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@thymikee thymikee merged commit be7e6e2 into react-native-community:main Jul 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants