Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put an upper bound on "**/Podfile" search depth #2480

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ephemer
Copy link
Contributor

@ephemer ephemer commented Aug 20, 2024

Summary:

This PR addresses #2479. Basically the unbounded search for **/Podfile never finishes on my machine. Normally the required depth should be 2, since ios/Podfile is the default location. So this still provides significantly more depth than most users should need.

Test Plan:

To be honest I'm not sure what causes this issue on my system, I only investigated what fixes it so far. It's clearly an issue with a deeply-nested submodule that we have, but I can't see what about it is causing the issue. If I run find . in my project root, all files (including the deeply-nested ones) can be printed within a few seconds, whereas fast-glob appears to never finish its search without this deep: 10 limitation.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

Thanks! Can you file that in fast-glob project as well so they can hopefully fix this?

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit b724448 into react-native-community:main Aug 21, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants