Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE in componentWillReceiveProps on line 150 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rakeshgajula
Copy link

The component was failing on line 150. The following line

newState.containerHeight= this.createHeight(nextProps)

was failing as newState was still unassigned. The fix is to check for validity of newState before assignment.

@kala888
Copy link

kala888 commented Nov 29, 2017

@cyqresig could you merge this to your project and release a new version?

@rakeshgajula
Copy link
Author

I have already fixed it in my project. I could release a new version but i don't think i can publish the release to NPM. It would be better if you can accept the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants