Implemented scrollDuringRotateOrZoom control for Google Maps #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherdro
approved these changes
Apr 20, 2021
|
Same issue here with latest version. I tried in android only. |
borjomemost
pushed a commit
to borjomemost/react-native-maps
that referenced
this pull request
May 6, 2022
…ative-maps#3784) * implemented scrollDuringRotateOrZoom control * fix lint issue * note in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
This PR exposes the native functionality of GoogleMaps to enable/disable moving the map while rotating or zooming.
The default behavior is to allow this, but I needed to disable it in my project.
This PR might fix:
#2572
How did you test this PR?
I tested this in the example project and in another one as well, by linking it in package.json to my fork of this library.
I tested both platforms, on physical devices
Steps to test:
"react-native-maps": "https://github.com/lukaszchopin/react-native-maps.git#scrollDuringRotateOrZoom"scrollDuringRotateOrZoomEnabledto false disables possibility to move map while rotating or zooming:<MapView scrollDuringRotateOrZoomEnabled={false} />