Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added Uno support #2067

Merged
merged 35 commits into from
Jun 26, 2019
Merged

feature: Added Uno support #2067

merged 35 commits into from
Jun 26, 2019

Conversation

weitzhandler
Copy link
Contributor

@weitzhandler weitzhandler commented Jun 12, 2019

This PR adds initial support for the Uno Platform.

@weitzhandler weitzhandler requested review from a team June 12, 2019 03:28
@weitzhandler weitzhandler requested review from a team June 17, 2019 04:47
@weitzhandler weitzhandler changed the title Added Uno ReactivePage Added Uno support Jun 17, 2019
@weitzhandler
Copy link
Contributor Author

weitzhandler commented Jun 17, 2019

Looks like generic type arguments are not supported.

Opened suggestion.

Anyway the solution I'm thinking of, is having on each view code-behind a dummy class that inherits from ReactiveUserControl<TViewModel> and is used as the XAML subclass, for example:

<v:ReactiveMainPage
  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
  xmlns:v="using:MyProject.Views"
  x:Class="MyProject.Views.MainPage"  
/>
namespace MyProject.Views
{
  public class ReactiveMainPage  : ReactiveUserControl<MainPageViewModel>
  { 
  }

  public sealed partial class MainPage : ReactiveMainPage
  {
  }
}

I'd be happy to hear about any other ideas of course.

@glennawatson
Copy link
Contributor

/// Note that UWP projects do not support the <c>TypeArguments</c> attribute. The XAML designer window in WPF projects also does not
that's the current proposal we have for users in our docs.

@weitzhandler
Copy link
Contributor Author

@jeromelaban can u take a look around here?

Copy link

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/ReactiveUI.Uno/ReactiveUI.Uno.csproj Outdated Show resolved Hide resolved
src/ReactiveUI.Uno/ReactiveUI.Uno.csproj Show resolved Hide resolved
@weitzhandler weitzhandler requested a review from a team June 18, 2019 04:23
@weitzhandler
Copy link
Contributor Author

weitzhandler commented Jun 18, 2019

@glennawatson Perhaps revert this commit, I opened #2078 for that.

@weitzhandler weitzhandler requested a review from a team June 19, 2019 05:32
README.md Outdated Show resolved Hide resolved
@glennawatson
Copy link
Contributor

Leave it in, I'm going to check some stuff the blazer guys did which would affect that portion of the code.

@glennawatson glennawatson changed the title Added Uno support feature: Added Uno support Jun 26, 2019
@glennawatson glennawatson merged commit 121458e into reactiveui:master Jun 26, 2019
@weitzhandler
Copy link
Contributor Author

Thank you guys for the hard work, you're amazing!

arda-a added a commit to arda-a/ReactiveUI that referenced this pull request Jul 5, 2019
madmonkey pushed a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019
@lock lock bot locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants