Merge pull request #606 from felipebaltazar/options-attribute

Options Attribute
reactiveui · Feb 16, 2019 · 5c33b7f · 5c33b7f
2 parents 846f5f8 + b44e75a
commit 5c33b7f
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/InterfaceStubGenerator.Core/InterfaceStubGenerator.cs b/InterfaceStubGenerator.Core/InterfaceStubGenerator.cs
@@ -25,7 +25,7 @@ namespace Refit.Generator
     public class InterfaceStubGenerator
     {
         static readonly HashSet<string> httpMethodAttributeNames = new HashSet<string>(
-            new[] { "Get", "Head", "Post", "Put", "Delete", "Patch" }
+            new[] { "Get", "Head", "Post", "Put", "Delete", "Patch", "Options" }
                 .SelectMany(x => new[] { "{0}", "{0}Attribute" }.Select(f => string.Format(f, x))));
 
         public InterfaceStubGenerator() : this(null, null) { }

diff --git a/Refit.Tests/RequestBuilder.cs b/Refit.Tests/RequestBuilder.cs
@@ -68,6 +68,9 @@ public interface IRestMethodInfoTests
         [Patch("/foo/{id}")]
         IObservable<string> PatchSomething(int id, [Body] string someAttribute);
 
+        [Options("/foo/{id}")]
+        Task<string> SendOptions(int id, [Body] string someAttribute);
+
         [Post("/foo/{id}")]
         Task<ApiResponse<bool>> PostReturnsApiResponse(int id);
 
@@ -383,6 +386,15 @@ public void UsingThePatchAttributeSetsTheCorrectMethod()
             Assert.Equal("PATCH", fixture.HttpMethod.Method);
         }
 
+        [Fact]
+        public void UsingOptionsAttribute()
+        {
+            var input = typeof(IRestMethodInfoTests);
+            var fixture = new RestMethodInfo(input, input.GetMethods().First(x => x.Name == nameof(IDummyHttpApi.SendOptions)));
+
+            Assert.Equal("OPTIONS", fixture.HttpMethod.Method);
+        }
+
         [Fact]
         public void ApiResponseShouldBeSet()
         {
@@ -478,6 +490,9 @@ public interface IDummyHttpApi
         [Patch("/foo/bar/{id}")]
         IObservable<string> PatchSomething(int id, [Body] string someAttribute);
 
+        [Options("/foo/bar/{id}")]
+        Task<string> SendOptions(int id, [Body] string someAttribute);
+
         [Get("/foo/bar/{id}")]
         Task<string> FetchSomeStuffWithQueryFormat([Query(Format = "0.0")] int id);
 
@@ -1271,7 +1286,6 @@ public void ICanPostAValueTypeIfIWantYoureNotTheBossOfMe()
             var expected = string.Format("\"{0}\"", guid);
             var output = factory(new object[] { 7, guid });
 
-
             Assert.Equal(expected, output.SendContent);
         }
     }

diff --git a/Refit/Attributes.cs b/Refit/Attributes.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http;
@@ -79,6 +79,17 @@ public override HttpMethod Method
         }
     }
 
+    [AttributeUsage(AttributeTargets.Method)]
+    public class OptionsAttribute : HttpMethodAttribute
+    {
+        public OptionsAttribute(string path) : base(path) { }
+
+        public override HttpMethod Method
+        {
+            get { return new HttpMethod("OPTIONS"); }
+        }
+    }
+
     [AttributeUsage(AttributeTargets.Method)]
     public class HeadAttribute : HttpMethodAttribute
     {