feat: fix form url encoded strings #1593 (#1752)

reactiveui · Jul 1, 2024 · a8fcd12 · a8fcd12
1 parent 5f82841
commit a8fcd12
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/Refit.Tests/RequestBuilder.cs b/Refit.Tests/RequestBuilder.cs
@@ -3241,6 +3241,29 @@ public void BodyContentGetsUrlEncoded()
             Assert.Equal("Foo=Something&Bar=100&Baz=", output.SendContent);
         }
 
+        [Fact]
+        public void BodyContentGetsUrlEncodedWithCollectionFormat()
+        {
+            var settings = new RefitSettings() { CollectionFormat = CollectionFormat.Csv };
+            var fixture = new RequestBuilderImplementation<IDummyHttpApi>(settings);
+            var factory = fixture.RunRequest("PostSomeUrlEncodedStuff");
+            var output = factory(
+                new object[]
+                {
+                    6,
+                    new
+                    {
+                        Foo = "Something",
+                        Bar = 100,
+                        FooBar = new [] {5,7},
+                        Baz = "" // explicitly use blank to preserve value that would be stripped if null
+                    }
+                }
+            );
+
+            Assert.Equal("Foo=Something&Bar=100&FooBar=5%2C7&Baz=", output.SendContent);
+        }
+
         [Fact]
         public void FormFieldGetsAliased()
         {

diff --git a/Refit/FormValueMultimap.cs b/Refit/FormValueMultimap.cs
@@ -65,7 +65,8 @@ public FormValueMultimap(object source, RefitSettings settings)
                     // see if there's a query attribute
                     var attrib = property.GetCustomAttribute<QueryAttribute>(true);
 
-                    if (value is not IEnumerable enumerable)
+                    // add strings/non enumerable properties
+                    if (value is not IEnumerable enumerable || value is string)
                     {
                         Add(
                             fieldName,