-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethrow for Better Stack Trace #1532
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 33 33
Lines 1685 1685
=======================================
Hits 1518 1518
Misses 167 167 ☔ View full report in Codecov by Sentry. |
Seems legit but what's with all of these whitespace changes? |
I knew you'd ask. I can drop the first commit, autoformat was just annoying me so I got them out of the way. The second commit seems useful? |
Done
I kept trimming a trailing space but reverted the rest. |
This comment was marked as outdated.
This comment was marked as outdated.
✨ |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Enhancement
What is the current behavior?
ApiException
call stack starts with something like:What is the new behavior?
ApiException
call stack starts with something like:Useful for observability to know which request method failed.
What might this PR break?
Folks that depend on the existing stack trace.
Please check if the PR fulfills these requirements
Other information:
👋