Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version and HttpVersionPolicy support for HttpRequestMessage #1800

Merged
merged 17 commits into from
Sep 15, 2024

Conversation

infofromca
Copy link
Contributor

Fixes #1799

@TimothyMakkison
Copy link
Contributor

I've never used Http version before but is there a usecase for setting the version for different requests. Perhaps by decorating an interface function with [HttpVersion(<version here>)].

@infofromca
Copy link
Contributor Author

infofromca commented Aug 31, 2024

I think it is not neccessary to have [HttpVersion()] , it is easy ( understanding) and resilience to Add Version and HttpVersionPolicy to the settings .

@infofromca infofromca closed this Sep 8, 2024
@infofromca infofromca reopened this Sep 8, 2024
@ChrisPulman ChrisPulman enabled auto-merge (squash) September 15, 2024 23:52
@ChrisPulman ChrisPulman merged commit e6f075e into reactiveui:main Sep 15, 2024
1 check passed
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (6ebeda5) to head (d171ac1).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   87.73%   83.74%   -3.99%     
==========================================
  Files          33       36       +3     
  Lines        2348     2449     +101     
  Branches      294      345      +51     
==========================================
- Hits         2060     2051       -9     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Version and HttpVersionPolicy support for HttpRequestMessage for Http 3
3 participants