Check if focusLaterElements array is empty before popping #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a check to see if the focusLaterElements array is empty, we end up calling `pop()` on an empty array—resulting in an undefined value—and inadvertently jump to the `catch` block when we attempt to call `focus()` on `undefined`. This ensures that if there are no existing elements to return focus to once our modal is closed (this happens often in a testing env), we do not throw a TypeError by accident.
indiesquidge
force-pushed
the
fix-return-focus-warning
branch
from
eb55ddb
to
d3b34ba
Compare
diasbruno
approved these changes
Dec 12, 2017
|
Thanks, @indiesquidge. Would you like to join and help manage the |
|
You have provided a lot of great reports and you really dig in to find a solution for issues. 👍 |
|
@diasbruno, yeah I'd love to help manage |
|
You can reach me on the email on my GitHub and the gitter channel I've created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #577.
Changes proposed
Without a check to see if the
focusLaterElementsarray is empty, we end up callingpop()on an empty array—resulting in an undefined value—and inadvertently jump to thecatchblock when we attempt to callfocus()onundefined.This PR ensures that if there are no existing elements to return focus to once our modal is closed (this happens often in a testing env), we do not throw a TypeError by accident.
Acceptance Checklist
CONTRIBUTING.md.