Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TransitionGroup error on quick toggle of components #15

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

scyrizales
Copy link
Contributor

I had this pull request to address this issue: #12

@xStrom
Copy link

xStrom commented Feb 9, 2017

How sure are we that returning is the correct behavior? By just immediately returning, currentlyTransitioningKeys will remain inconsistent.

Previous attempts (#6710, #6745) only guarded execution of code that directly depends on component being defined, but still executed the other parts of the function like currentlyTransitioningKeys cleanup.

Unless there's a good case for immediately returning, I think just guarding the component usage is a better solution.

@jquense
Copy link
Collaborator

jquense commented Feb 9, 2017

I agree with @xStrom, we shouln't return early here, but guard the actual callback so the rest of the state can be properly cleaned up

Fix TransitionGroup error on quick toggle of components
@scyrizales
Copy link
Contributor Author

@xStrom I have just updated the PR

@xStrom
Copy link

xStrom commented Feb 9, 2017

Looks good, I think we should merge this.

@jquense jquense merged commit de38b24 into reactjs:master Feb 9, 2017
jony89 added a commit to jony89/react-transition-group that referenced this pull request Jan 27, 2018
fixes reactjs#12 using reactjs#15 for v1 as well.

Not all of us has been moved to v2 (especially those of us who are still using `material-ui`  < v1-beta),
Yet, this is critical bug fix .

hopefully a version with that fix will be released soon ? :)
jquense pushed a commit that referenced this pull request Jan 29, 2018
* Fix TransitionGroup error for v1 as well

fixes #12 using #15 for v1 as well.

Not all of us has been moved to v2 (especially those of us who are still using `material-ui`  < v1-beta),
Yet, this is critical bug fix .

hopefully a version with that fix will be released soon ? :)

* Update TransitionGroup.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants