Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing info about changes in StrictMode discoverable through useEffect docs #4649

Open
cytrowski opened this issue May 9, 2022 · 1 comment · May be fixed by #4650
Open

Missing info about changes in StrictMode discoverable through useEffect docs #4649

cytrowski opened this issue May 9, 2022 · 1 comment · May be fixed by #4650

Comments

@cytrowski
Copy link

This ticket was originally reported in the React issue as a potential bug: facebook/react#24502

After a short discussion with @gaearon I volunteered to update the docs so that once someone learns about empty dependencies array in useEffect simulating componentDidMount they won't be surprised to see effect callback run twice on mount.
@cytrowski cytrowski linked a pull request May 9, 2022 that will close this issue
Open
cytrowski added a commit to cytrowski/reactjs.org that referenced this issue May 9, 2022
@cytrowski
Adds missing info about changes in StrictMode related to useEffect
c4265a9 
closes reactjs#4649
@cytrowski
Copy link
Author

@gaearon I know you guys are working really hard on moving beta.reactjs.org out of "beta" but is there a chance this little improvement to the old useEffect docs will get merged? 🥺 (You asked for it in May: facebook/react#24502 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing info about changes in StrictMode related to useEffect cytrowski/reactjs.org
1 participant
@cytrowski