Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behaviour of setting state inside useLayoutEffect #7096

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

OliverJAsh
Copy link
Contributor

As discussed: facebook/react#17334 (comment)

@eps1lon You will probably have a better idea of how to word this. I was also wondering if we should add a note under "Measuring layout before the browser repaints the screen". This is exactly what I was trying to achieve before realising the behaviour with regards to useEffect.

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:33am
react-dev ✅ Ready (Inspect) Visit Preview Aug 7, 2024 9:33am

Copy link

github-actions bot commented Aug 7, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@eps1lon eps1lon merged commit 6671ba7 into reactjs:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants