Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynchronousSink - verb is missing in javadoc #3835

Closed
ilya-ulyanov opened this issue Jun 28, 2024 · 3 comments · Fixed by #3838
Closed

SynchronousSink - verb is missing in javadoc #3835

ilya-ulyanov opened this issue Jun 28, 2024 · 3 comments · Fixed by #3838
Labels
status/need-user-input This needs user input to proceed type/documentation A documentation update
Milestone
3.7.0-M4

Comments

@ilya-ulyanov
Copy link
Contributor

Documentation Issue

The javadoc for the SynchronousSink says:
"... You can FluxSink or MonoSink based generators for these situations."

Improvement Suggestion

The above should be rephrased by adding a verb, for instance - "use", so it becomes:
"... You can use FluxSink or MonoSink based generators for these situations."
@ilya-ulyanov ilya-ulyanov added the type/documentation A documentation update label Jun 28, 2024
@chemicL
Copy link
Member

chemicL commented Jul 2, 2024

Thanks for the report. Are you open to contributing this fix? It doesn't require signing the CLA.

@chemicL chemicL added the status/need-user-input This needs user input to proceed label Jul 2, 2024
@ilya-ulyanov
Copy link
Contributor Author

Yes, will do. Thanks.

ilya-ulyanov added a commit to ilya-ulyanov/reactor-core that referenced this issue Jul 3, 2024
@ilya-ulyanov
[reactor#3835] Fix SynchronousSink javadoc
02f9200
@ilya-ulyanov ilya-ulyanov mentioned this issue Jul 3, 2024
Merged
@ilya-ulyanov
Copy link
Contributor Author

I have opened a PR - #3838

@chemicL chemicL added this to the 3.7.0-M4 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/need-user-input This needs user input to proceed type/documentation A documentation update
Projects
None yet
Milestone
3.7.0-M4
Development

Successfully merging a pull request may close this issue.

[#3835] Fix SynchronousSink javadoc ilya-ulyanov/reactor-core
2 participants
@chemicL @ilya-ulyanov