Fix FluxReplay cancel and subscribe race between two Subscribers #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
reviewed
Feb 19, 2024
reactor-core/src/jcstress/java/reactor/core/publisher/FluxReplayStressTest.java
Show resolved
Hide resolved
chemicL
reviewed
Feb 19, 2024
reactor-core/src/jcstress/java/reactor/core/publisher/FluxReplayStressTest.java
Show resolved
Hide resolved
chemicL
reviewed
Feb 19, 2024
reactor-core/src/jcstress/java/reactor/core/publisher/FluxReplayStressTest.java
Show resolved
Hide resolved
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
chemicL
changed the title
chemicL
added a commit
that referenced
this pull request
Jun 21, 2024
chemicL
added a commit
that referenced
this pull request
Jun 21, 2024
chemicL
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that in case of racing between multiple subscribers we ensure that the potential outdated FluxReplay.connection which one of the subscribers can join while creating a different connection instance at the level FluxRefCnt is not causing a new FluxReplay.connection to be prematurely closed up on the previous connection instance replay all the values