Dispose TimedRunnable upon TimedWorker shutdown #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TimedRunnable` that is created using a `TimedWorker` was not disposed upon `Worker` shutdown. That led the pending tasks timers to run forever, causing leaks. This change keeps track of created `TimedRunnable` instances by the `TimedWorker`, allowing to dispose the resources responsibly. Resolves #3844
violetagg
approved these changes
Jul 25, 2024
chemicL
added a commit
that referenced
this pull request
Jul 25, 2024
chemicL
added a commit
that referenced
this pull request
Jul 25, 2024
|
@violetagg thank you for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TimedRunnablethat is created using aTimedWorkerwas not disposed uponWorkershutdown. That led the pending tasks timers to run forever, causing leaks.This change keeps track of created
TimedRunnableinstances by theTimedWorker, allowing to dispose the resources responsibly.Resolves #3844