Add receive batch to receiver #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohamed-gara Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@mohamed-gara Thank you for signing the Contributor License Agreement! |
mohamed-gara
force-pushed
the
add_receive_batch_to_receiver
branch
from
0f51188
to
9d3b5d0
Compare
artembilan
requested changes
Aug 31, 2023
mohamed-gara
force-pushed
the
add_receive_batch_to_receiver
branch
from
9d3b5d0
to
16ae4fd
Compare
mohamed-gara
force-pushed
the
add_receive_batch_to_receiver
branch
from
16ae4fd
to
335f8b1
Compare
mohamed-gara
force-pushed
the
add_receive_batch_to_receiver
branch
from
335f8b1
to
4fd4021
Compare
artembilan
approved these changes
Aug 31, 2023
garyrussell
suggested changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM; please add some documentation for the receiveBatch method.
https://projectreactor.io/docs/kafka/release/reference/#api-guide-receiver
mohamed-gara
force-pushed
the
add_receive_batch_to_receiver
branch
from
250be81
to
7e7f903
Compare
artembilan
approved these changes
Sep 11, 2023
garyrussell
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation to resolve #261. I have chosen the name proposed by @serejke here for the new method in KafkaReceiver.
Actually, in our product I use receive() with the bufferTimeout operator. But it is not the best solution to consume a record batch. With the receiveBatch() method batch consumption will be easier.