Skip to content

Commit

Permalink
Temporarily rename JNI's package.cpp wrapper
Browse files Browse the repository at this point in the history
To ease debugging with conflicting file names between that and SDK's package.cpp
  • Loading branch information
Juan Corona committed Dec 10, 2014
1 parent e78d78a commit 7d2b0df
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Platform/Android/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ LOCAL_SRC_FILES := \
Platform/Android/jni/jni/jni_ptr.cpp \
Platform/Android/jni/epub3.cpp \
Platform/Android/jni/container.cpp \
Platform/Android/jni/package.cpp \
Platform/Android/jni/packagejni.cpp \
Platform/Android/jni/iri.cpp \
Platform/Android/jni/resource_stream.cpp

Expand Down
3 changes: 2 additions & 1 deletion Platform/Android/Application.mk
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
APP_ABI := armeabi-v7a
APP_PLATFORM := android-19
NDK_TOOLCHAIN_VERSION := 4.9
APP_STL := gnustl_static
APP_STL := gnustl_static
APP_OPTIM := debug
2 changes: 1 addition & 1 deletion Platform/Android/jni/container.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "epub3.h"
#include "helpers.h"
#include "container.h"
#include "package.h"
#include "packagejni.h"


using namespace std;
Expand Down
2 changes: 1 addition & 1 deletion Platform/Android/jni/epub3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "epub3.h"
#include "helpers.h"
#include "container.h"
#include "package.h"
#include "packagejni.h"
#include "iri.h"
#include "resource_stream.h"

Expand Down
File renamed without changes.
File renamed without changes.

3 comments on commit 7d2b0df

@danielweck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jccr indeed I see how the renaming could be very useful during debugging (because of file/class name collision), but shouldn't this change either be (1) temporary, or (2) applied to all other homonyms consistently?

@jccr
Copy link
Member

@jccr jccr commented on 7d2b0df Jan 6, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielweck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, recorded an issue: #151

Please sign in to comment.