-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibooks metadata properties parsing? #108
Comments
In addition to iBooks, what about others? (Sony, etc.) Although readium-js aims at covering the most common basis (including support for proprietary Apple metadata extensions), perhaps the readium-sdk should remain EPUB 2/3 strict? (just wondering) |
danielweck
added a commit
that referenced
this issue
Nov 11, 2014
…). Partial implementation in the sense that we do not support Sony/Amazon/etc. metadata. This is mostly a bug fix to address the most common case of the "display-options" iBooks XML. #108 Also addressed #121 ("rendition" prefix mapping was missing) + minor edits (unused code): erroneous / out-of-date array offsets for map initialisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When OPF layout metadata is missing (e.g. rendition pre-paginated), readium-js probes the iBooks XML for equivalent information:
https://github.com/readium/readium-js/blob/develop/epub-modules/epub/src/models/package_document_parser.js#L96
...so, should readium-sdk do the same? Right now, an EPUB with missing "pre-paginated" metadata defaults to reflowable in SDKLaunchers, whereas the iBooks property is correctly picked-up in Chrome extension and cloud reader (because of the special iBooks parsing implemented in readium-js).
(Note that this issue was unearthed by readium/SDKLauncher-iOS#35 )
The text was updated successfully, but these errors were encountered: