missing line in package.cpp

[a-klimashevsky]

There is a missing line "env->DeleteLocalRef(media_overlay_id);" in a package.cpp file (Java_org_readium_sdk_android_Package_nativeGetSpineItems method).

[rkwright]

Sorry, don't understand this issue. Can you clarify? What, exactly, is the issue?

[datalogics-bhaugen]

I think the issue that is being raised here is that in package.cpp a jstring is created that is named media_overlay_id but that object is not deleted like the other jstring objects are deleted starting around line 631 in package.cpp .

I think this causes a leak of some sort but my understanding of this part of the JNI has never been crystal clear.

[a-klimashevsky]

exactly!
in my case I have a book with 771 spine items

[yteitel]

Hello,
I thought that this issue has been solved a while ago.
I work currently in the branch release/0.14 and in package.cpp line 637,
there is actually:
env->DeleteLocalRef(media_overlay_id);
I encourage you to check that the fix has been pushed to develop. I know
that the master branch is pretty old for now.

Yonathan

2014-04-24 13:44 GMT+02:00 Alex Klimashevsky notifications@github.com:

exactly!
in my case I have a book with 771 spine items

Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41270502
.

[datalogics-bhaugen]

@yteitel is right! It looks like this has been fixed in the develop branch

[rkwright]

Closing this as fixed.