Jenkins build android #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will attempt to compile the JNI layer as an Android library project for use with the Launcher for Android.
Before building the Java code, compile the native code!
datalogics-bhaugen
added a commit
that referenced
this pull request
May 28, 2014
Jenkins build android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
I think, but did not try, that the pre-compile step could be moved around based on how developers want to use it, if they want to use it, but for now it seems like the JNI headers are being checked into the repository (:+1:) but building the C++ code first would not work when there are new methods added to the JNI.
So I am proposing this unless some of the Android developers would like it to be changed, and I would be happy to make the change to suit the developers needs! 😄
(There is a jenkins plugin that will generate this script but I was not sure if/how it could be modified after it was generated so I opted to just generate it now and get it checked into the repo to avoid that problem)
@rkwright, are you still keeping the develop branch from changing? If so this can wait to be merged until you are ready!