Abstract bindings on ppx #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
approved these changes
Sep 5, 2023
ppx/test/output_locations.expected
Outdated
Comment on lines
755
to
758
| (pos_bol 0) (pos_cnum 18))) | ||
| (loc_end | ||
| ((pos_fname generated_locations.ml) (pos_lnum 1) | ||
| (pos_bol 0) (pos_cnum 23))) | ||
| (pos_bol 0) (pos_cnum 65))) |
There was a problem hiding this comment.
These are pretty big changes, do you know what happened?
ppx/src/reactjs_jsx_ppx.ml
Outdated
|
|
||
| let componentLike ~loc props return = | ||
| Ptyp_constr | ||
| ( { loc; txt = Ldot (Lident "React", "componentLike") }, |
There was a problem hiding this comment.
This and ReactDOM.domProps are types, not bindings. But I guess it is ok :)
There was a problem hiding this comment.
I guess it's fine, right?
Maybe Bindings.Types.* is an overkill?
Co-authored-by: Javier Chávarri <javier.chavarri@gmail.com>
Merged
jchavarri
force-pushed
the
Remove-legacy-apis
branch
from
ca22de0
to
3d3728d
Compare
jchavarri
force-pushed
the
Remove-legacy-apis
branch
from
8395692
to
6b1b9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously to remove the legacy APIs I want to make sure we don't rely on those on the ppx. I'm doing this small abstraction to have an easy way to know which bindings we use from the ppx and improving a big the quality of this beast.
This refactor should be harmless. I have tested the location test and seems ok.