Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/devicefarm #112

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Conversation

tomvachon
Copy link
Contributor

How should I handle Regions which dont support the service (or make the error cleaner)

ERRO[0001] Listing with resources.ResourceLister failed. Please report this to https://github.com/rebuy-de/aws-nuke/issues/new.
!!! RequestError: send request failed
!!! caused by: Post https://devicefarm.us-east-1.amazonaws.com/: dial tcp: lookup devicefarm.us-east-1.amazonaws.com: no such host
ERRO[0002] Listing with resources.ResourceLister failed. Please report this to https://github.com/rebuy-de/aws-nuke/issues/new.
!!! RequestError: send request failed
!!! caused by: Post https://devicefarm.us-east-2.amazonaws.com/: dial tcp: lookup devicefarm.us-east-2.amazonaws.com: no such host
us-west-2 - DeviceFarmProject - 'arn:aws:devicefarm:us-west-2:999999999999:project:fc78472b-96d0-4234-aa2e-0cfa72dc3db6' - would remove
Scan complete: 1 total, 1 nukeable, 0 filtered.

@bethge
Copy link
Contributor

bethge commented Mar 8, 2018

Good point. Not sure if we have even considered this thus far. We might need to raise an issue for this. @svenwltr wdyt?

@bethge bethge mentioned this pull request Mar 8, 2018
@tomvachon
Copy link
Contributor Author

@bethge & @svenwltr this is happening all over the place now as I get to the non-primitives. How about we filter out any error which has "no such host" at the project level? That would at least mean there is no endpoint for that service in that region

@tomvachon
Copy link
Contributor Author

re-squashed this

@tomvachon tomvachon changed the title Feature/devicepool Feature/devicefarm Mar 12, 2018
@svenwltr svenwltr merged commit be6be00 into rebuy-de:master Mar 13, 2018
@tomvachon tomvachon deleted the feature/devicepool branch March 16, 2018 17:03
@svenwltr svenwltr added the kind/resource Adding or changing AWS resources. label Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/resource Adding or changing AWS resources.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants