Add ElasticSearchService Domain and SQS Queue #84
Conversation
|
Updated SqsQueue to SQSQueue for consistency |
resources/sqs-queues.go
Outdated
|
|
||
| type SQSQueue struct { | ||
| svc *sqs.SQS | ||
| queueurl *string |
There was a problem hiding this comment.
Sorry for being the pedantic one, but would you use queueURL to follow golang style conventions? The AWS SDK does not follow it, but we decided to follow it since it is the de-facto standard.
resources/sqs-queues.go
Outdated
| register("SQSQueue", ListSqsQueues) | ||
| } | ||
|
|
||
| func ListSqsQueues(sess *session.Session) ([]Resource, error) { |
There was a problem hiding this comment.
Same as above: ListSQSQueues
|
|
||
| type ESDomain struct { | ||
| svc *elasticsearchservice.ElasticsearchService | ||
| domainname *string |
|
Updated these, Ill check my next PR now |
|
@tomvachon Sorry for the late response. Your PRs look good so far. Could you squash them, so there is only one commit per PR and no merge commit? That would make the testing easier for us. |
|
Yea, I can. Should I do it retroactively or going forward?
…On Mon, Mar 5, 2018 at 8:51 AM, Sven Walter ***@***.***> wrote:
@tomvachon <https://github.com/tomvachon> Sorry for the late response.
Your PRs look good so far. Could you squash them, so there is only one
commit per PR and no merge commit? That would make the testing easier for
us.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUQRaqu--V8kV6lRBddDFA4XYkAzLBlks5tbULkgaJpZM4SZ9Uj>
.
|
|
Doing it retroactively would be nice. |
|
Give me a few minutes, I'm trying to remember how to do this again ;) |
|
@svenwltr my head isn't functioning, how do I squash them again, sorry for the dumb question |
|
|
Ok, squashing now, I had to rebase master to avoid the merge commit too |
|
Thank you very much. We will review and merge soon. |
Note, deletion of ESS Domains is very long in wait times