Update dependencies #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
der-eismann
force-pushed
the
update-logrus
branch
from
d0de579
to
261445d
Compare
der-eismann
force-pushed
the
update-logrus
branch
from
0a080d3
to
9ab0f9a
Compare
svenwltr
reviewed
Mar 16, 2021
| @@ -276,10 +278,15 @@ func (r *Runner) RunArtifacts(ctx context.Context, cmd *cobra.Command, args []st | |||
| case "deb": | |||
| version, release := r.Info.Version.StringRelease() | |||
|
|
|||
| bindir := "/usr/share/bin" | |||
| files := map[string]string{} | |||
| bindir := "/usr/bin" | |||
There was a problem hiding this comment.
Because literally nothing goes in this directory, it wasn't even existing on my machine. Self-compiled stuff is in /usr/local/bin, packages go in /usr/bin
There was a problem hiding this comment.
Fair enough. I was sure I had this in my $PATH, but it is not there.
svenwltr
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies since logrus 1.8.1 contains a critical fix
https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md#181