Remove translateStyle function and export #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary in 2017 but is not needed anymore - all browsers now support CSS transforms and transitions without prefixes. This is probably a breaking change. The function export was not documented but I guess if it's exported from index then it's part of the public API?
ckifer
approved these changes
Oct 17, 2023
|
Although... in the spirit of semver we could just do a major version release of react-smooth for consumers and accept it as 'non-breaking' for recharts |
|
I'm not fussed about browser support but in this PR I have removed a function export - that's the breaking part. |
PavelVanecek
commented
Oct 18, 2023
| import AnimateGroup from './AnimateGroup'; | ||
|
|
||
| export { configSpring, configBezier, AnimateGroup, translateStyle }; |
There was a problem hiding this comment.
Removing this export will break when recharts imports it: https://github.com/recharts/recharts/blob/master/src/component/Tooltip.tsx#L5
which is why I would do a major release.
|
Oh yeah makes sense, we can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary in 2017 but is not needed anymore - all browsers now support CSS transforms and transitions without prefixes.
This is a breaking change. The function export was not documented but I guess if it's exported from index then it's part of the public API. Recharts will break for example :)
https://caniuse.com/?search=transforms
Also discussed on Slack: https://recharts.slack.com/archives/C042Q5K5UDC/p1697529536898929