Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-smooth v4 "breaking changes" #87

Merged
merged 2 commits into from
Jan 29, 2024
Merged

react-smooth v4 "breaking changes" #87

merged 2 commits into from
Jan 29, 2024

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented Jan 29, 2024

Doing this so we can remove the peer dependency on prop-types in recharts and bump our react peerDep

  • prop-types upgrade minors and react-transition-group -> 4.x
  • prop-types move to dependencies - consumers don't need to care about the version of this package
  • remove prop-types from externals
  • remove support for react < 16.8 - recharts breaks with <16.8 so upgrading this should be fine
  • bump to 4.x

Note 3.x still breaks recharts so this can't be added right away

Testing: published with yalc and messed with it locally

@ckifer
Copy link
Member Author

ckifer commented Jan 29, 2024

@PavelVanecek @nikolasrieble tagging as more of an FYI than anything, I'm just going to publish this so its there, we don't necessarily need to consume it right away (refactoring for v3 required anyways)

@ckifer ckifer merged commit 3ad17a7 into master Jan 29, 2024
1 check passed
@ckifer ckifer deleted the v4 branch January 29, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant