Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge alloy-rs/ruint (ruint2) #261

Closed
wants to merge 20 commits into from
Closed

feat: merge alloy-rs/ruint (ruint2) #261

wants to merge 20 commits into from

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 13, 2023

Motivation

Internal changes:

Public changes listed in CHANGELOG.md

Dependabot:

Other:

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@DaniPopes DaniPopes changed the title Dani/sync feat: merge alloy-rs/ruint (ruint2) Jul 13, 2023
@DaniPopes DaniPopes marked this pull request as ready for review July 13, 2023 00:44
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 96.47% and project coverage change: -1.41 ⚠️

Comparison is base (35167fb) 84.90% compared to head (b06aece) 83.49%.

❗ Current head b06aece differs from pull request most recent head 016fe90. Consider uploading reports for the commit 016fe90 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   84.90%   83.49%   -1.41%     
==========================================
  Files          50       51       +1     
  Lines        5967     5490     -477     
==========================================
- Hits         5066     4584     -482     
- Misses        901      906       +5     
Impacted Files Coverage Δ
crates/ruint-macro/src/lib.rs 96.42% <ø> (ø)
crates/ruint/src/algorithms/add.rs 91.66% <ø> (ø)
crates/ruint/src/algorithms/div/knuth.rs 100.00% <ø> (ø)
crates/ruint/src/algorithms/div/mod.rs 100.00% <ø> (ø)
crates/ruint/src/algorithms/div/reciprocal.rs 100.00% <ø> (ø)
crates/ruint/src/algorithms/div/small.rs 86.77% <ø> (ø)
crates/ruint/src/algorithms/gcd/matrix.rs 93.54% <ø> (ø)
crates/ruint/src/algorithms/gcd/mod.rs 84.27% <ø> (ø)
crates/ruint/src/algorithms/mod.rs 100.00% <ø> (ø)
crates/ruint/src/algorithms/mul_redc.rs 100.00% <ø> (ø)
... and 41 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,25 +0,0 @@
name: Security Audit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of deleting the audit workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced with cargo deny. pls read pr description

@@ -1,128 +1,118 @@
name: CI

on: [push, pull_request]
on:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summarize the intent of the changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically alloy-core workflow + kept coverage workflow

.editorconfig Outdated Show resolved Hide resolved
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of this PR is too broad for us to merge as temporary maintainers. First, I'm unwilling to overwrite repo conventions with our own opinions. We're stewards, not owners here. Second, there's no effective record of the changes being made, as all changes are in a single PR, with functional and non-functional changes mixed into the individual commits.

Next steps should be:

  1. Remove non-functional changes:
  • Formatter settings
  • .github folder changes
  • File renames
  • repo directory structure
  • etc
  1. Open issues for each functional change. Each change should be a single PR with an associated issue

@DaniPopes DaniPopes marked this pull request as draft July 17, 2023 22:29
@DaniPopes DaniPopes mentioned this pull request Jul 17, 2023
3 tasks
@DaniPopes
Copy link
Contributor Author

Closed in favor of #262, #263, and #264

@DaniPopes DaniPopes closed this Jul 17, 2023
@DaniPopes DaniPopes deleted the dani/sync branch July 17, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants