-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge alloy-rs/ruint (ruint2) #261
Conversation
chore: update .github/
perf: do not box proptest strategies
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 84.90% 83.49% -1.41%
==========================================
Files 50 51 +1
Lines 5967 5490 -477
==========================================
- Hits 5066 4584 -482
- Misses 901 906 +5
☔ View full report in Codecov by Sentry. |
@@ -1,25 +0,0 @@ | |||
name: Security Audit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of deleting the audit workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with cargo deny. pls read pr description
@@ -1,128 +1,118 @@ | |||
name: CI | |||
|
|||
on: [push, pull_request] | |||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summarize the intent of the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically alloy-core workflow + kept coverage workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of this PR is too broad for us to merge as temporary maintainers. First, I'm unwilling to overwrite repo conventions with our own opinions. We're stewards, not owners here. Second, there's no effective record of the changes being made, as all changes are in a single PR, with functional and non-functional changes mixed into the individual commits.
Next steps should be:
- Remove non-functional changes:
- Formatter settings
.github
folder changes- File renames
- repo directory structure
- etc
- Open issues for each functional change. Each change should be a single PR with an associated issue
Motivation
Internal changes:
feature = "nightly"
: https://github.com/recmo/uint/blob/35167fbf0406c8f925608225225f91f5612e371b/build.rs#L4C8-L4C76git rm Cargo.lock
ruint
to1.9.0
, andruint-macro
to1.1.0
Public changes listed in
CHANGELOG.md
Dependabot:
Other:
Solution
PR Checklist