Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(meta): add MSRV policy, remove Cargo.lock #265

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore(meta): add MSRV policy, remove Cargo.lock #265

merged 1 commit into from
Jul 19, 2023

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 17, 2023 •
edited
Loading

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@DaniPopes DaniPopes marked this pull request as draft July 17, 2023 23:20
@DaniPopes DaniPopes changed the title chore(meta): update README.md, config files, remove Cargo.lock chore(meta): add MSRV policy, remove Cargo.lock Jul 18, 2023
@DaniPopes DaniPopes marked this pull request as ready for review July 18, 2023 16:49
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (5faa6ff) 83.56% compared to head (ae2c141) 83.47%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   83.56%   83.47%   -0.10%     
==========================================
  Files          51       51              
  Lines        5483     5483              
==========================================
- Hits         4582     4577       -5     
- Misses        901      906       +5
Impacted Files Coverage Δ
src/lib.rs 81.05% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

prestwich
prestwich approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are de-minimis 👍

@prestwich prestwich merged commit 223c97e into recmo:main Jul 19, 2023
12 of 13 checks passed
@DaniPopes DaniPopes deleted the dani/meta branch July 19, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich