Correction for command timeout during pubsub #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A timeout of a non-subscribe command will be ignored during pubsub. It will be handled as an idle timeout and a response is awaited for.
Disconnect when a sent non-subscribe command triggers a timeout.
|
@michael-grunder There is a lot of testcase in this PR, and can be seen as to much noise, so I'm open to just merging the correction if that's the case :) |
|
Having caused as many segfaults as I have over the years, I'm pretty much always in favor of more test cases 😄 Thanks again, merged. I will get your other pending PR merged today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timeout of a non-subscribe command is ignored during pubsub,
and will be handled as an idle timeout and the response is still awaited for.
This correction triggers a disconnect instead, the same behavior as when not in the subscribed state.