Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: remove dict.c form hiredis_sources #1055

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

Lipraxde
Copy link
Contributor

Commit c6b8bd7 to make all functions in dict.c static. If a CMake project set warning unused functions, and include hiredis using add_subdirectory , this cause warnings / errors.

Commit c6b8bd7 to make all functions in dict.c static. If a CMake project set warning unused functions, and include hiredis using add_subdirectory , this cause warnings / errors.
Copy link
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get CMake and make builds more alike, even that dict is not part of the external symbols (nm -g) nor included in the installed headers.
Building hiredis itself with something like -Wall today will also trigger the warnings you mentioned.

@michael-grunder michael-grunder merged commit c57cad6 into redis:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants