Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper for setting TCP_USER_TIMEOUT socket option #1188

Merged
merged 2 commits into from
May 29, 2023

Conversation

zuiderkwast
Copy link
Contributor

This adds another option in the same style as the TCP KeepAlive feature, i.e. passing the option directly to setsockopt() without storing it in the context, meaning it does not happen automatically after redisReconnect().

It is already possible to achieve this by taking the fd out of the redisContext as c->fd, so it is not strictly necessary to add this.

Documentation is added in README also for the keepalive feature.

…unctions

Documentation for redisReconnect() and the setters of socket options:

* redisKeepAlive()
* redisEnableKeepAliveWithInterval()
* redisSetTcpUserTimeout()
@michael-grunder michael-grunder merged commit b6a052f into redis:master May 29, 2023
@michael-grunder
Copy link
Collaborator

This is great, thanks!

The test failures appear totally unrelated so I'll figure those out in another commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants