Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure functionality without _MSC_VER definition #1194

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

windyakin
Copy link
Contributor

When building with a compiler that is not the Microsoft C/C++ compiler (MSVC), I get the error error: "_MSC_VER" is not defined.

I checked the code and it looks like you just want to make sure _MSV_VER is defined, so I changed it from #if to #ifdef.

@windyakin
Copy link
Contributor Author

I think the cause of the error is #1193 (-Werror)

@windyakin
Copy link
Contributor Author

@yossigo @michael-grunder please check it?

@michael-grunder michael-grunder self-requested a review June 8, 2023 19:00
Copy link
Collaborator

@michael-grunder michael-grunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I don't see any way that it's harmful.

@michael-grunder michael-grunder merged commit 052f99a into redis:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants