Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default SSL verification path #928

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

adobeturchenko
Copy link

Adding missing default verify path for client certificates.

Issue causing connection fail if certificate is not specified in connection settings (it's optional so it doesn't need to be specified).
Fixes #927 however issue is not skipping verification but setting default path.

@michael-grunder
Copy link
Collaborator

I'm going through all of our open PRs since I'm putting together a new version soon.

I'm inclined to merge this as the feature adds quite a lot of convenience (e.g. to connect to a cloud provider Redis endpoint) without having to do all of the work manually via redisInitiateSSL.

The only real question I have is whether we need to put this behind a redisConnectWithOptions option as it would change Hiredis' current behavior by default.

@michael-grunder michael-grunder merged commit 5392adc into redis:master Sep 8, 2022
@michael-grunder
Copy link
Collaborator

Merged, thanks!

We can bikeshed whether we need to put it behind an option when putting together the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hiredis_ssl] Add support for skipping certificate verification
3 participants