Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain AS to Schema object #2950

Merged
merged 15 commits into from
May 26, 2022
Merged

Conversation

Avital-Fine
Copy link
Contributor

Resolves #2943

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #2950 (85f1b64) into master (2b7dd63) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 85f1b64 differs from pull request most recent head 6b56927. Consider uploading reports for the commit 6b56927 to get more accurate results

@@             Coverage Diff              @@
##             master    #2950      +/-   ##
============================================
- Coverage     53.45%   53.45%   -0.01%     
- Complexity     3336     3338       +2     
============================================
  Files           216      216              
  Lines         13320    13324       +4     
  Branches        775      775              
============================================
+ Hits           7120     7122       +2     
- Misses         5953     5955       +2     
  Partials        247      247              
Impacted Files Coverage Δ
...ain/java/redis/clients/jedis/search/FieldName.java 25.64% <50.00%> (ø)
...c/main/java/redis/clients/jedis/search/Schema.java 42.28% <50.00%> (-1.17%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 89.37% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7dd63...6b56927. Read the comment docs.

zeekling
zeekling previously approved these changes Mar 26, 2022
@Avital-Fine Avital-Fine requested a review from chayim April 12, 2022 07:58
@sazzad16 sazzad16 changed the title Chain As to Search Schema Chain AS to Schema class May 26, 2022
@sazzad16 sazzad16 changed the title Chain AS to Schema class Chain AS to Schema object May 26, 2022
@sazzad16 sazzad16 merged commit df30995 into redis:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add field with an alias to a RediSearch schema?
4 participants