Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new TimeSeries arguments #3082

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Conversation

sazzad16
Copy link
Collaborator

  • LATEST
  • EMPTY
  • TWA
  • BUCKETTIMESTAMP
  • ALIGNTIMESTAMP

- LATEST
- EMPTY
- TWA
- BUCKETTIMESTAMP
- ALIGNTIMESTAMP
@sazzad16 sazzad16 marked this pull request as draft July 20, 2022 12:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #3082 (bfcde2c) into master (f7156ee) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

❗ Current head bfcde2c differs from pull request most recent head 1d637b3. Consider uploading reports for the commit 1d637b3 to get more accurate results

@@             Coverage Diff              @@
##             master    #3082      +/-   ##
============================================
- Coverage     52.19%   51.89%   -0.30%     
+ Complexity     3345     3344       -1     
============================================
  Files           218      219       +1     
  Lines         13649    13715      +66     
  Branches        786      793       +7     
============================================
- Hits           7124     7118       -6     
- Misses         6283     6351      +68     
- Partials        242      246       +4     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/CommandObjects.java 63.32% <0.00%> (-0.16%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.63% <0.00%> (-0.06%) ⬇️
src/main/java/redis/clients/jedis/Pipeline.java 7.79% <0.00%> (-0.02%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 11.29% <0.00%> (-0.03%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 52.39% <0.00%> (-0.12%) ⬇️
...edis/clients/jedis/timeseries/AggregationType.java 0.00% <0.00%> (ø)
...redis/clients/jedis/timeseries/TSCreateParams.java 0.00% <0.00%> (ø)
...va/redis/clients/jedis/timeseries/TSGetParams.java 0.00% <0.00%> (ø)
...a/redis/clients/jedis/timeseries/TSMGetParams.java 0.00% <0.00%> (ø)
...redis/clients/jedis/timeseries/TSMRangeParams.java 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7156ee...1d637b3. Read the comment docs.

@sazzad16 sazzad16 marked this pull request as ready for review July 20, 2022 15:14
@sazzad16 sazzad16 requested a review from chayim July 20, 2022 15:17
chayim
chayim previously requested changes Jul 21, 2022
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps docstrings? Sure - we don't have these everywhere.. but it's good to start

@sazzad16 sazzad16 requested review from chayim and removed request for chayim July 21, 2022 10:33
@sazzad16 sazzad16 merged commit 2ec720f into redis:master Jul 21, 2022
@sazzad16 sazzad16 deleted the ts-more-args branch July 21, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment