-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TDIGEST commands #3097
Support TDIGEST commands #3097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3097 +/- ##
============================================
- Coverage 66.55% 66.51% -0.05%
- Complexity 4386 4419 +33
============================================
Files 243 244 +1
Lines 14225 14318 +93
Branches 851 854 +3
============================================
+ Hits 9468 9524 +56
- Misses 4387 4423 +36
- Partials 370 371 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
private void assertTotalWeight(String key, double totalWeight) { | ||
Map<String, Object> info = client.tdigestInfo(key); | ||
assertEquals(totalWeight, Double.parseDouble((String) info.get("Merged weight")) | ||
+ Double.parseDouble((String) info.get("Unmerged weight")), 0.01); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shacharPash I don't get what your exact question is but here is my first attempt to answer:
JUnit, the library we based our tests upon, deprecated assertEquals(double, double) and suggested to use assertEquals(double, double, double).
This reverts commit b021566.
No description provided.