Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TDIGEST commands #3097

Merged
merged 15 commits into from
Sep 20, 2022
Merged

Support TDIGEST commands #3097

merged 15 commits into from
Sep 20, 2022

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Aug 7, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #3097 (5e20e59) into master (a692b47) will decrease coverage by 0.04%.
The diff coverage is 64.81%.

@@             Coverage Diff              @@
##             master    #3097      +/-   ##
============================================
- Coverage     66.55%   66.51%   -0.05%     
- Complexity     4386     4419      +33     
============================================
  Files           243      244       +1     
  Lines         14225    14318      +93     
  Branches        851      854       +3     
============================================
+ Hits           9468     9524      +56     
- Misses         4387     4423      +36     
- Partials        370      371       +1     
Impacted Files Coverage Δ
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.22% <0.00%> (-0.30%) ⬇️
src/main/java/redis/clients/jedis/Pipeline.java 17.12% <0.00%> (-0.24%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 11.43% <0.00%> (-0.16%) ⬇️
.../redis/clients/jedis/bloom/TDigestMergeParams.java 83.33% <83.33%> (ø)
.../main/java/redis/clients/jedis/BuilderFactory.java 75.28% <100.00%> (ø)
...ain/java/redis/clients/jedis/CommandArguments.java 78.33% <100.00%> (-0.70%) ⬇️
.../main/java/redis/clients/jedis/CommandObjects.java 85.15% <100.00%> (+0.30%) ⬆️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.73% <100.00%> (+0.36%) ⬆️
...ava/redis/clients/jedis/bloom/BFReserveParams.java 100.00% <100.00%> (ø)
.../redis/clients/jedis/bloom/RedisBloomProtocol.java 98.52% <100.00%> (+0.16%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sazzad16 sazzad16 added this to the 4.3.0 milestone Aug 7, 2022
@sazzad16 sazzad16 marked this pull request as draft August 7, 2022 16:26
@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental labels Aug 8, 2022
@sazzad16 sazzad16 marked this pull request as ready for review August 9, 2022 11:21
@sazzad16 sazzad16 requested a review from chayim August 9, 2022 11:24
private void assertTotalWeight(String key, double totalWeight) {
Map<String, Object> info = client.tdigestInfo(key);
assertEquals(totalWeight, Double.parseDouble((String) info.get("Merged weight"))
+ Double.parseDouble((String) info.get("Unmerged weight")), 0.01);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shacharPash I don't get what your exact question is but here is my first attempt to answer:

JUnit, the library we based our tests upon, deprecated assertEquals(double, double) and suggested to use assertEquals(double, double, double).

@sazzad16 sazzad16 linked an issue Aug 24, 2022 that may be closed by this pull request
@sazzad16 sazzad16 removed the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Aug 24, 2022
chayim
chayim previously approved these changes Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment