Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work FT.CREATE and FT.ALTER #3120

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Re-work FT.CREATE and FT.ALTER #3120

merged 6 commits into from
Sep 6, 2022

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@sazzad16 sazzad16 linked an issue Aug 26, 2022 that may be closed by this pull request
@sazzad16 sazzad16 changed the title Re-work FT.CREATE Re-work FT.CREATE and FT.ALTER Aug 26, 2022
@sazzad16 sazzad16 added this to the 4.3.0 milestone Aug 26, 2022
@sazzad16 sazzad16 marked this pull request as draft August 26, 2022 14:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #3120 (4562b76) into master (e41904e) will decrease coverage by 0.43%.
The diff coverage is 45.22%.

@@             Coverage Diff              @@
##             master    #3120      +/-   ##
============================================
- Coverage     66.69%   66.26%   -0.44%     
- Complexity     4234     4287      +53     
============================================
  Files           219      227       +8     
  Lines         13757    14023     +266     
  Branches        799      832      +33     
============================================
+ Hits           9175     9292     +117     
- Misses         4248     4368     +120     
- Partials        334      363      +29     
Impacted Files Coverage Δ
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.58% <0.00%> (-0.06%) ⬇️
src/main/java/redis/clients/jedis/Pipeline.java 17.16% <0.00%> (-0.04%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 11.61% <0.00%> (-0.03%) ⬇️
...java/redis/clients/jedis/search/IndexDataType.java 0.00% <0.00%> (ø)
...ients/jedis/search/RediSearchPipelineCommands.java 0.00% <0.00%> (ø)
...ava/redis/clients/jedis/search/FTCreateParams.java 30.76% <30.76%> (ø)
...lients/jedis/search/schemafields/NumericField.java 31.57% <31.57%> (ø)
...is/clients/jedis/search/schemafields/TagField.java 36.84% <36.84%> (ø)
...s/clients/jedis/search/schemafields/TextField.java 37.50% <37.50%> (ø)
...is/clients/jedis/search/schemafields/GeoField.java 54.54% <54.54%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bsbodden
bsbodden previously approved these changes Sep 6, 2022
Copy link
Contributor

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sazzad16 sazzad16 marked this pull request as ready for review September 6, 2022 16:17
@sazzad16 sazzad16 merged commit 2cec9a5 into redis:master Sep 6, 2022
@sazzad16 sazzad16 deleted the ft-create branch September 6, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WITHSUFFIXTRIE to FT.CREATE
3 participants