Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better binary support for SET command with GET option #3134

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Sep 11, 2022

This PR addresses and mitigates #3132 in a non-breaking way.

@codecov-commenter
Copy link

Codecov Report

Merging #3134 (5549732) into master (ce82171) will decrease coverage by 0.13%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #3134      +/-   ##
============================================
- Coverage     66.60%   66.46%   -0.14%     
- Complexity     4375     4377       +2     
============================================
  Files           242      242              
  Lines         14207    14223      +16     
  Branches        853      853              
============================================
- Hits           9462     9454       -8     
- Misses         4372     4396      +24     
  Partials        373      373              
Impacted Files Coverage Δ
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.52% <0.00%> (-0.06%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 11.58% <0.00%> (-0.03%) ⬇️
...ain/java/redis/clients/jedis/params/SetParams.java 100.00% <ø> (ø)
.../main/java/redis/clients/jedis/CommandObjects.java 84.85% <100.00%> (+0.04%) ⬆️
src/main/java/redis/clients/jedis/Jedis.java 84.95% <100.00%> (+0.02%) ⬆️
src/main/java/redis/clients/jedis/Pipeline.java 17.36% <100.00%> (+0.19%) ⬆️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.36% <100.00%> (+0.06%) ⬆️
...ava/redis/clients/jedis/util/RedisInputStream.java 64.13% <0.00%> (-14.14%) ⬇️
...nts/jedis/providers/ClusterConnectionProvider.java 72.72% <0.00%> (-5.46%) ⬇️
...lients/jedis/executors/ClusterCommandExecutor.java 75.38% <0.00%> (-3.08%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sazzad16 sazzad16 added this to the 4.3.0 milestone Sep 11, 2022
@sazzad16 sazzad16 changed the title Proper binary support for SET command with GET option Better binary support for SET command with GET option Sep 11, 2022
@sazzad16 sazzad16 merged commit ee012f8 into redis:master Sep 11, 2022
@sazzad16 sazzad16 deleted the set-get-binary branch September 11, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants