Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redis command: CLIENT TRACKINGINFO #3751

Merged

Conversation

cemasma
Copy link
Contributor

@cemasma cemasma commented Mar 1, 2024

This pull request covers the implementation of the issue below to support CLIENT TRACKINGINFO command.
#2881

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Please:

  1. Cover RESP3 Reply.
  2. Test RESP3 Reply.

src/main/java/redis/clients/jedis/BuilderFactory.java Outdated Show resolved Hide resolved
@cemasma cemasma force-pushed the enhancement=add-tracking-info-command branch from 03ee2c1 to bac0296 Compare March 10, 2024 22:32
@cemasma cemasma requested a review from sazzad16 March 10, 2024 22:35
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.62%. Comparing base (a2386fe) to head (32bc71a).
Report is 1 commits behind head on master.

❗ Current head 32bc71a differs from pull request most recent head bac0296. Consider uploading reports for the commit bac0296 to get more accurate results

Files Patch % Lines
...n/java/redis/clients/jedis/resps/TrackingInfo.java 96.29% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3751      +/-   ##
============================================
+ Coverage     75.57%   75.62%   +0.04%     
- Complexity     4956     4960       +4     
============================================
  Files           300      301       +1     
  Lines         15055    15085      +30     
  Branches       1131     1134       +3     
============================================
+ Hits          11378    11408      +30     
+ Misses         3182     3180       -2     
- Partials        495      497       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 2394380 into redis:master Mar 11, 2024
5 checks passed
@sazzad16 sazzad16 added this to the 5.2.0 milestone Mar 11, 2024
sazzad16 pushed a commit that referenced this pull request Jul 10, 2024
Co-authored-by: Cem Asma <cemasma@Cems-MBP.home>
@sazzad16 sazzad16 modified the milestones: 5.2.0, 5.1.4 Jul 10, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants