Support the MAXAGE option for CLIENT KILL #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue redis#3731 Starting with Redis 7.6, the CLIENT KILL command has a new option, called MAXAGE, to kill clients older than a given age. Add support for this new option.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3754 +/- ##
============================================
- Coverage 75.40% 75.37% -0.04%
Complexity 4931 4931
============================================
Files 300 300
Lines 15054 15055 +1
Branches 1131 1131
============================================
- Hits 11352 11348 -4
- Misses 3207 3211 +4
- Partials 495 496 +1 ☔ View full report in Codecov by Sentry. |
sazzad16
reviewed
Mar 5, 2024
src/test/java/redis/clients/jedis/commands/jedis/ClientCommandsTest.java
Outdated
Show resolved
Hide resolved
sazzad16
requested changes
Mar 7, 2024
src/test/java/redis/clients/jedis/commands/jedis/ClientCommandsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
sazzad16
approved these changes
Mar 7, 2024
sazzad16
added a commit
that referenced
this pull request
Jul 10, 2024
* Support the MAXAGE option for CLIENT KILL Starting with Redis 7.6, the CLIENT KILL command has a new option, called MAXAGE, to kill clients older than a given age. Add support for this new option. * Ensure clients are closed in some tests * More concise unit test code Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com> --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com> Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3731
Starting with Redis 7.6, the CLIENT KILL command has a new option, called MAXAGE, to kill clients older than a given age. Add support for this new option.