Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo pipelined tests #3767

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Geo pipelined tests #3767

merged 3 commits into from
Mar 13, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Mar 12, 2024

No description provided.

@gerzse gerzse requested a review from sazzad16 March 12, 2024 14:53
@gerzse gerzse marked this pull request as draft March 12, 2024 14:53
@gerzse gerzse added the testing label Mar 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.00%. Comparing base (5733cd6) to head (8f74c5e).
Report is 1 commits behind head on master.

❗ Current head 8f74c5e differs from pull request most recent head b70da4e. Consider uploading reports for the commit b70da4e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3767      +/-   ##
============================================
+ Coverage     75.76%   76.00%   +0.24%     
- Complexity     4986     5020      +34     
============================================
  Files           301      301              
  Lines         15085    15085              
  Branches       1134     1134              
============================================
+ Hits          11429    11466      +37     
+ Misses         3159     3117      -42     
- Partials        497      502       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The general pattern seems to be
<Pooled|Clustered|Pipelined><Category>CommandsTest.
@gerzse gerzse marked this pull request as ready for review March 13, 2024 08:54
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Pooled|Clustered|Pipelined>CommandsTest

Pipelined is not comparable to pooled/clustered. You can have pipelined with both pooled and clustered; i.e. Pooled|ClusteredPipelinedCommandsTest is possible. There could be better names but current names are better than your proposed ones.

@gerzse
Copy link
Contributor Author

gerzse commented Mar 13, 2024

<Pooled|Clustered|Pipelined>CommandsTest

Pipelined is not comparable to pooled/clustered. You can have pipelined with both pooled and clustered; i.e. Pooled|ClusteredPipelinedCommandsTest is possible. There could be better names but current names are better than your proposed ones.

Ok, got it. I changed back the names.

@sazzad16 sazzad16 merged commit 7096d74 into redis:master Mar 13, 2024
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants