-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo pipelined tests #3767
Geo pipelined tests #3767
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3767 +/- ##
============================================
+ Coverage 75.76% 76.00% +0.24%
- Complexity 4986 5020 +34
============================================
Files 301 301
Lines 15085 15085
Branches 1134 1134
============================================
+ Hits 11429 11466 +37
+ Misses 3159 3117 -42
- Partials 497 502 +5 ☔ View full report in Codecov by Sentry. |
The general pattern seems to be <Pooled|Clustered|Pipelined><Category>CommandsTest.
f00961b
to
8c53f34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Pooled|Clustered|Pipelined>CommandsTest
Pipelined is not comparable to pooled/clustered. You can have pipelined with both pooled and clustered; i.e. Pooled|ClusteredPipelinedCommandsTest is possible. There could be better names but current names are better than your proposed ones.
Ok, got it. I changed back the names. |
No description provided.