Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last entry id for XREADs and support XREADs reply as map #3791

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Mar 26, 2024


Task breakdown (ToDo):

  • new StreamEntryID for less confusion
  • new XREAD and XREADGROUP support as map
  • command tests
  • pipeline tests

@sazzad16 sazzad16 added this to the 5.2.0 milestone Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 79.48%. Comparing base (bad18b9) to head (7e54283).

Files Patch % Lines
.../main/java/redis/clients/jedis/BuilderFactory.java 90.47% 1 Missing and 1 partial ⚠️
.../main/java/redis/clients/jedis/PipeliningBase.java 0.00% 2 Missing ⚠️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3791      +/-   ##
============================================
+ Coverage     79.44%   79.48%   +0.03%     
- Complexity     5685     5695      +10     
============================================
  Files           301      301              
  Lines         15231    15274      +43     
  Branches       1186     1190       +4     
============================================
+ Hits          12101    12140      +39     
- Misses         2551     2556       +5     
+ Partials        579      578       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gerzse
gerzse previously approved these changes Mar 27, 2024
* {@code XREAD STREAMS mystream +}
*/
// TODO: unify with MAXIMUM_ID ??
public static final StreamEntryID XREAD_LAST_ENTRY = new StreamEntryID() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be XREAD_LAST_ENTRY = MAXIMUM_ID, to make it obvious that it is only an alias. Somehow I find it more informative to have different names, depending on the usage context.

src/main/java/redis/clients/jedis/StreamEntryID.java Outdated Show resolved Hide resolved
@sazzad16 sazzad16 merged commit a02b2eb into redis:master Mar 27, 2024
7 checks passed
@sazzad16 sazzad16 deleted the stream-ids-and-xread-as-map branch March 27, 2024 13:15
@sazzad16 sazzad16 modified the milestones: 5.2.0, 5.1.4 Jul 10, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XREAD, XREADGROUP reading from last message of stream
2 participants