-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last entry id for XREADs and support XREADs reply as map #3791
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3791 +/- ##
============================================
+ Coverage 79.44% 79.48% +0.03%
- Complexity 5685 5695 +10
============================================
Files 301 301
Lines 15231 15274 +43
Branches 1186 1190 +4
============================================
+ Hits 12101 12140 +39
- Misses 2551 2556 +5
+ Partials 579 578 -1 ☔ View full report in Codecov by Sentry. |
* {@code XREAD STREAMS mystream +} | ||
*/ | ||
// TODO: unify with MAXIMUM_ID ?? | ||
public static final StreamEntryID XREAD_LAST_ENTRY = new StreamEntryID() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be XREAD_LAST_ENTRY = MAXIMUM_ID
, to make it obvious that it is only an alias. Somehow I find it more informative to have different names, depending on the usage context.
Task breakdown (ToDo):