Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Output NameSpace format #4

Merged
merged 4 commits into from
May 17, 2017
Merged

#3 Output NameSpace format #4

merged 4 commits into from
May 17, 2017

Conversation

xqinghu
Copy link

@xqinghu xqinghu commented May 30, 2016

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2016

Coverage Status

Coverage decreased (-3.08%) to 82.388% when pulling 32bf5c9 on xqinghu:fix into 4dc55fb on rednaga:master.

@coveralls
Copy link

coveralls commented May 30, 2016

Coverage Status

Coverage decreased (-0.09%) to 85.373% when pulling 892bf63 on xqinghu:fix into 4dc55fb on rednaga:master.

@strazzere
Copy link
Member

Thanks for submitting this! Is there anyway we can bolster the coverage on the tests to ensure this part of the code is actually covered?

https://coveralls.io/builds/6384655/source?filename=src%2Fmain%2Fjava%2Fandroid%2Fcontent%2Fres%2FAXMLResource.java#L232

It appears that the test added, doesn't actually look for the namespace - it's just printing out the XML. This inherently appears to "test" it from a coveralls perspective since those statements are reached, however it isn't actually testing any of the code -- just outputting it to the terminal;
892bf63

@coveralls
Copy link

coveralls commented Jun 2, 2016

Coverage Status

Coverage decreased (-0.09%) to 85.373% when pulling b7ba2cc on xqinghu:fix into 4dc55fb on rednaga:master.

@coveralls
Copy link

coveralls commented Jun 2, 2016

Coverage Status

Coverage increased (+0.4%) to 85.843% when pulling dd51b1b on xqinghu:fix into 4dc55fb on rednaga:master.

@strazzere strazzere merged commit b434204 into rednaga:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants